search

canonical / canonicalwebteam.discourse

GNU Lesser General Public License v3.0
11 stars 16 forks source link

Engage pages and Takeovers scope creep? #157

Open sparkiegeek opened 1 year ago

sparkiegeek commented 1 year ago

I believe it's just ubuntu.com that uses takeovers? If so, can the code be moved to that project and not carried around by every discourse-based-docs project?

See hardcoded ubuntu.com ids - https://github.com/canonical/canonicalwebteam.discourse/blob/main/canonicalwebteam/discourse/models.py#L85

hardcoded ubuntu.com errors https://github.com/canonical/canonicalwebteam.discourse/blob/main/canonicalwebteam/discourse/app.py#L539

there's lots to point to this not belonging in this here project