canonical / canonicalwebteam.discourse

GNU Lesser General Public License v3.0
11 stars 16 forks source link

Make title expansion behavior uniform across hyperlinked and non-hyperlinked titles #168

Open tmihoc opened 1 year ago

tmihoc commented 1 year ago

Currently, (a) hyperlinked vs. (b) non-hyperlinked titles behave differently with respect to caret expansion:

See for example the titles under https://charmhub.io/topics/canonical-observability-stack/reference

@simskij would like like (b) to be like (a) -- in both cases it should be possible to expand by clicking on either the text or the caret.

I think this behavior makes sense in general, so it would be good to roll it out across the board.

bartaz commented 11 months ago

The distinction between hyperlinked and non-hyperlinked items in side navigation is on purpose.

Hyperlinked items link to their own page, that's why they are clickable. By clicking on hyperlinked item you go to the linked page. Yes, it "expands" the child items, because we show the child items of the page you just navigated to. So expanding is rather a side effect, not directly caused by clicking on hyperlinked item.

Non-hyperlinked items don't have their own page, therefore are not clickable. If we make them clickable they will be no visible difference between them and hyperlinked items, which is a UX issue. User will never know if clicking on side navigation will link to new page or just expand.

I can't talk for the design, but I believe the idea was not to mix non-hyperlinked and hyperlinked items. If you use hyperlinked (and expandable) items, all of them should be created that way (all of them should have a page they link to).

tmihoc commented 11 months ago

So expanding is rather a side effect, not directly caused by clicking on hyperlinked item.

Got it, thanks!