Check it a header contains a link - Githubissues

canonical / canonicalwebteam.discourse

GNU Lesser General Public License v3.0

11 stars 16 forks source link

Check it a header contains a link #174

Closed anthonydillon closed 1 year ago

anthonydillon commented 1 year ago

Done

Improved the null checking on the next link

QA

Go to https://ubuntu.com/landscape/docs/quickstart-deployment and see it errors

Locally change requirements.txt of ubuntu.com project to:

# canonicalwebteam.discourse==5.4.3
canonicalwebteam.discourse @ git+https://github.com/anthonydillon/canonicalwebteam.discourse@check-header-has-link`

Run dotrun clean && dotrun
Go to http://0.0.0.0:8001/landscape/docs/quickstart-deployment
See that the page loads
Check a few pages all load correctly

carkod commented 1 year ago

@sparkiegeek which page were you fixing in https://github.com/canonical/canonicalwebteam.discourse/commit/9da26d343b128d075bf4bccb131b8114c5920cc5 ? can you provide an example to QA?