canonical / canonicalwebteam.flask-base

3 stars 10 forks source link

chore: Bump Flask to 2.3.3 and update dependencies #72

Closed petesfrench closed 4 months ago

petesfrench commented 4 months ago

Done

QA

carkod commented 4 months ago

Can you bump the version of flask-base? if you don't do it won't automatically trigger a renovate PR and you can't really reference it in the requirements.txt.

Also, lint and test are stuck, can you take a look? Maybe rebase could work as I've merged the new versions of actions/checkout

petesfrench commented 4 months ago

@samhotep Any idea why these checks are hanging?

petesfrench commented 4 months ago

@carkod Can you take another look please

carkod commented 4 months ago

@samhotep Any idea why these checks are hanging?

Try updating the labels.

Screenshot 2024-07-04 at 18 53 04

By labels I mean the Ubuntu version there. If we are still using Github runners, then that image is deprecated otherwise, I think we need to reach out to the Github actions self-hosted runners team

samhotep commented 4 months ago

As @carkod suggested I've updated the versions, but the checks are borked now - taking a look

samhotep commented 4 months ago

@petesfrench some tests are failing,

you're almost good to merge :)