search

canonical / cassandra-k8s-operator

Apache License 2.0
1 stars 4 forks source link

Update tox.ini #41

Closed jnsgruk closed 3 years ago

jnsgruk commented 3 years ago

Remove whitelist_externals to tidy up our language, the setting is also deprecated in favour of allowlist_externals

https://tox.readthedocs.io/en/latest/config.html#conf-allowlist_externals

dstathis commented 3 years ago

By the way, is there a way to just say "I don't approve" without requesting changes?

jnsgruk commented 3 years ago

Surely tox is installed independently through pip?

dstathis commented 3 years ago

Surely tox is installed independently through pip?

It certainly could be. I installed it using apt. There is more or less no reason to develop in a virtualenv for charms, especially when using tox so I have things installed using the system package manager.

As a note, charmcraft itself throws an error if you try to use the pip installed version.

dstathis commented 3 years ago

After some discussion I have decided to merge this. The issue on system installed tox is only a warning.