search

canonical / charm-duplicity

A charm that provides functionality for both manual and automatic backups for a deployed application
0 stars 3 forks source link

flake8 6.0.0 raises ValueError for inline comments on ignore rule lines #19

Closed jneo8 closed 11 months ago

jneo8 commented 11 months ago

This issue is currently affecting multiple charms after the flake8 6.0.0 release. flake8 expects to find the comments on their separate lines.

miles@mertkirpici-bastion-focal:~/repo/charm-openstack-service-checks$ make lint Running lint checks lint installed: black==22.10.0,click==8.1.3,flake8==6.0.0,flake8-colors==0.1.9,flake8-docstrings==1.6.0,flake8-import-order==0.18.2,mccabe==0.7.0,mypy-extensions==0.4.3,pathspec==0.10.2,pep8-naming==0.13.2,platformdirs==2.5.4,pycodestyle==2.10.0,pydocstyle==6.1.1,pyflakes==3.0.1,snowballstemmer==2.2.0,tomli==2.0.1,typing-extensions==4.4.0 lint run-test-pre: PYTHONHASHSEED='3949094690' lint run-test: commands[0] | flake8 Traceback (most recent call last): File "/home/miles/repo/charm-openstack-service-checks/src/.tox/lint/bin/flake8", line 8, in sys.exit(main()) File "/home/miles/repo/charm-openstack-service-checks/src/.tox/lint/lib/python3.8/site-packages/flake8/main/cli.py", line 23, in main app.run(argv) File "/home/miles/repo/charm-openstack-service-checks/src/.tox/lint/lib/python3.8/site-packages/flake8/main/application.py", line 198, in run self._run(argv) File "/home/miles/repo/charm-openstack-service-checks/src/.tox/lint/lib/python3.8/site-packages/flake8/main/application.py", line 186, in _run self.initialize(argv) File "/home/miles/repo/charm-openstack-service-checks/src/.tox/lint/lib/python3.8/site-packages/flake8/main/application.py", line 165, in initialize self.plugins, self.options = parse_args(argv) File "/home/miles/repo/charm-openstack-service-checks/src/.tox/lint/lib/python3.8/site-packages/flake8/options/parse_args.py", line 53, in parse_args opts = aggregator.aggregate_options(option_manager, cfg, cfg_dir, rest) File "/home/miles/repo/charm-openstack-service-checks/src/.tox/lint/lib/python3.8/site-packages/flake8/options/aggregator.py", line 30, in aggregate_options parsed_config = config.parse_config(manager, cfg, cfg_dir) File "/home/miles/repo/charm-openstack-service-checks/src/.tox/lint/lib/python3.8/site-packages/flake8/options/config.py", line 131, in parseconfig raise ValueError( ValueError: Error code '#TODO' supplied to 'ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$' ERROR: InvocationError for command /home/miles/repo/charm-openstack-service-checks/src/.tox/lint/bin/flake8 (exited with code 1) ____ summary ____ ERROR: lint: commands failed make: *** [Makefile:63: lint] Error 1

Imported from Launchpad using lp2gh.