search

canonical / charm-juju-backup-all

Juju Backup All - a charm to perform Juju and database backups
Apache License 2.0
1 stars 5 forks source link

Remove Jinja2 due to security alert, add runs-on for self-hosted runner #31

Closed zxhdaze closed 6 months ago

zxhdaze commented 6 months ago

There was a security alert about a vulnerable version of jinja. After investigation I found jinja2 is not used hence I removed it. Specifying runs-on for self hosted runner, otherwise arm will picked up by default. Using xlarge to avoid disk ran out.

chanchiwai-ray commented 6 months ago

Question: should we target main branch or master branch?

samuelallan72 commented 6 months ago

Question: should we target main branch or master branch?

It looks like main is now the default branch. I updated the base to main for this PR. :)

rgildein commented 6 months ago 
* Robert's comment about the reason the `runs-on` was updated (it was defaulting to self-hosted, but failed to run on arm64, so it needed the extra filters).  I'm not sure if `xlarge` is required, but sounds reasonable for func tests? CC @rgildein )

I was also asking @zxhdaze to try to use only large and not xlarge, since the snap juju-backup-all is using only large and these have similar bundles. @zxhdaze Did you try to use only large?