search

canonical / charm-lldpd

LLDPd charm
Other
1 stars 8 forks source link

Add support 18.04 #27

Closed xtrusia closed 4 months ago

xtrusia commented 5 months ago

Add support 18.04 as the customer is using bionic. Also focal should be supported in charmhub.

xtrusia commented 5 months ago

This doesn't actually add functional tests to test on bionic. I have found that this fails in practice. Before we merge this, we should have functional tests for bionic.

I built the charm with 'charmcraft pack' and tried to deploy "./lldpd_ubuntu-18.04-amd64.charm" but it failed as juju 3.1 doesn't seem to support bionic. with juju 2.9.49, I can deploy it. If so, we don't support bionic for this charm anymore?

Thanks a lot.

xtrusia commented 4 months ago

This doesn't actually add functional tests to test on bionic. I have found that this fails in practice. Before we merge this, we should have functional tests for bionic.

I built the charm with 'charmcraft pack' and tried to deploy "./lldpd_ubuntu-18.04-amd64.charm" but it failed as juju 3.1 doesn't seem to support bionic. with juju 2.9.49, I can deploy it. If so, we don't support bionic for this charm anymore?

Thanks a lot.

I've checked code further and inserted and changed some dependencies. but not sure it is correct yet. please review my changes. Thanks a lot.

xtrusia commented 4 months ago

had a discussion and created stable/bionic to support bionic.