canonical / charm-microceph

Charm to deploy/manage microceph

Apache License 2.0

2 stars 9 forks source link

Only restart once with bulk config setting #117

Closed sabaini closed 1 month ago

sabaini commented 1 month ago

Description

When updating several config items at once, only restart services at the end. This is relevant for the RGW configuration which sets

Also pin operator libs for harness compatibility

Fixes #113 #96

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] CleanCode (Code refactor, test updates, does not introduce functional changes)
[ ] Documentation update (Doc only change)

How Has This Been Tested?

Manual test to verify

Unittests updated

Contributor's Checklist

Please check that you have:

[x] self-reviewed the code in this PR.
[ ] added code comments, particularly in hard-to-understand areas.
[ ] updated the user documentation with corresponding changes.
[ ] added tests to verify effectiveness of this change.

sabaini commented 1 month ago

Network spaces test is failing atm but in local testing it did succeed. I believe there's substrate issues in play here