search

canonical / charm-microceph

Charm to deploy/manage microceph
Apache License 2.0
2 stars 9 forks source link

Updated public address lookup method to rely on Ceph conf #36

Closed UtkarshBhatthere closed 5 months ago

UtkarshBhatthere commented 5 months ago

The updated logic uses ceph.conf file to read the mon host addresses, hence the charm logic can run on any MicroCeph unit.

sabaini commented 5 months ago

I'm ok with this change in general, but one question presents itself about this code: we're getting a single mon ipaddr here to answer broker requests, but should we not set all available mon ipaddrs on these broker req? (I appreciate this was the same behaviour we had previously, just wondering if this could be improved in general) :eyes: @UtkarshBhatthere

UtkarshBhatthere commented 5 months ago

I would be totally up with updating all mon ips (best case scenario :D). Was concerned how the clients would react to multiple IPs where they expected just one in the relation databag.

UtkarshBhatthere commented 5 months ago

maybe we should add new param in the relation databag and deprecate the older one ?