canonical / charm-microceph

Charm to deploy/manage microceph
Apache License 2.0
2 stars 9 forks source link

Fix osds parsing regex #42

Closed gboutry closed 5 months ago

gboutry commented 5 months ago

Osds parsing regex didn't return a match when the location contained a dot. (such as fqdn do)

UtkarshBhatthere commented 5 months ago

Thanks for the change Guillaume. I have one nit though. Since now, microceph snap supports outputting the disk list command in json, using regex seems a bit overkill. Also, the tabular output format may change in future. May I suggest to use json output instead?

gboutry commented 5 months ago

I'm using microceph 0+git.0819c49 817 reef/stable canonical✓ held and the command does not have json format.

List servers in the cluster

Usage:
  microceph disk list [flags]

Global Flags:
  -d, --debug       Show all debug messages
  -h, --help        Print help
      --state-dir   Path to store state information
  -v, --verbose     Show all information messages
      --version     Print version number
UtkarshBhatthere commented 5 months ago

@gboutry given that disk list json is still a few days away from being available in stable, is this change still relevant ? If that's the case i'll merge it..

gboutry commented 5 months ago

It's still relevant :)