Closed gboutry closed 9 months ago
Thanks for the change Guillaume. I have one nit though. Since now, microceph snap supports outputting the disk list command in json, using regex seems a bit overkill. Also, the tabular output format may change in future. May I suggest to use json output instead?
I'm using microceph 0+git.0819c49 817 reef/stable canonical✓ held
and the command does not have json format.
List servers in the cluster
Usage:
microceph disk list [flags]
Global Flags:
-d, --debug Show all debug messages
-h, --help Print help
--state-dir Path to store state information
-v, --verbose Show all information messages
--version Print version number
@gboutry given that disk list json is still a few days away from being available in stable, is this change still relevant ? If that's the case i'll merge it..
It's still relevant :)
Osds parsing regex didn't return a match when the location contained a dot. (such as fqdn do)