search

canonical / charm-microceph

Charm to deploy/manage microceph
Apache License 2.0
2 stars 9 forks source link

Implement the 'default-pool-size' option #57

Closed lmlg closed 2 months ago

lmlg commented 3 months ago

Instead of setting the default replication factor to 1 by default, this PR aims to let users select what default value they wish to be applied.

lmlg commented 3 months ago

Heya, thanks for that! One minor nit inside.

Also I'm wondering if we might want to add a small functest for this. Could e.g. in juju-single-test set RF=1 and only add 1 OSD there

After refactoring, the config hook calls out to set_pool_size, which has its own functional test, so I would say it's already being tested, but I can cook up something specific for it if it's needed.

pmatulis commented 2 months ago

The configuration option description looks good to me.

UtkarshBhatthere commented 2 months ago

The change looks good to me, +1 for @sabaini's suggestion because single node single disk deployment are one of the primary use cases for this config.