jedel1043 commented 6 months ago

Description

This change allows integrating with microceph using the ceph-mds relation, which is required by charms such as ceph-fs to create filesystems on the cluster. Do note that this only allows creating filesystems; a separate PR (#71) is in place to allow creating cephfs clients using broker requests.

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] CleanCode (Code refactor, test updates, does not introduce functional changes)
[ ] Documentation update (Doc only change)

How Has This Been Tested?

NOTE: All functional changes should accompany corresponding tests (unit tests, functional tests etc).

A functional test on the CI pipeline.

Contributor's Checklist

Please check that you have:

[x] self-reviewed the code in this PR.
[x] added code comments, particularly in hard-to-understand areas.
[x] updated the user documentation with corresponding changes.
[x] added tests to verify effectiveness of this change.

jedel1043 commented 6 months ago

Not sure about how to go over testing this. I have local deployments using ceph-fs, but I think mocking it using ops would require adding a new relation library to charm-ops-inteface-ceph-client which probaby needs its own design.

lmlg commented 6 months ago

Not sure about how to go over testing this. I have local deployments using ceph-fs, but I think mocking it using ops would require adding a new relation library to charm-ops-inteface-ceph-client which probaby needs its own design.

A functional test would do the job. Essentially, we would need a model to be deployed where ceph-fs is related to microceph and one simple command that requires authorization completes successfully.

jedel1043 commented 6 months ago

Added a functional test for the mds relation.

UtkarshBhatthere commented 6 months ago

/canonical/self-hosted-runners/run-workflows 6b54e9148de2fac91d25cd3a8e29d5d630012792

UtkarshBhatthere commented 6 months ago

@jedel1043 I have merged some CI patches, rebasing with main should make the tests better.

jedel1043 commented 6 months ago

Rebased on main. I think it needs another workflow approval.

UtkarshBhatthere commented 6 months ago

/canonical/self-hosted-runners/run-workflows adfada1ca23292f2fbd7bd5f4b3b77a484b95b45

UtkarshBhatthere commented 6 months ago

/canonical/self-hosted-runners/run-workflows 9349bc4c6d99fb8025c9f4560376d27d1f69ad5d

sabaini commented 6 months ago

/canonical/self-hosted-runners/run-workflows 9349bc4

jedel1043 commented 6 months ago

No idea why the Juju upgrade test job is failing. Reading the logs, it seems like a unit is not upgrading the Microceph snap to reef/stable correctly? Though, that problem seems to be external to this PR.

lmlg commented 6 months ago

/canonical/self-hosted-runners/run-workflows https://github.com/canonical/charm-microceph/commit/9349bc4c6d99fb8025c9f4560376d27d1f69ad5d

UtkarshBhatthere commented 6 months ago

/canonical/self-hosted-runners/run-workflows e8ed07542974a8adb3128126488a1a9724cf6769

canonical / charm-microceph

feat: add support for the `ceph-mds` relation #68

Description

Type of change

How Has This Been Tested?

Contributor's Checklist