canonical / charm-microceph

Charm to deploy/manage microceph
Apache License 2.0
2 stars 9 forks source link

Integrations for microceph rgw #86

Closed hemanthnakkina closed 5 months ago

hemanthnakkina commented 5 months ago

Description

Add following integrations to charm microceph

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Added Unit test cases. Manual testing with sunbeam.

Contributor's Checklist

Please check that you have:

Depends on:

hemanthnakkina commented 5 months ago

This PR is ready for review

hemanthnakkina commented 5 months ago

Hey @hemanthnakkina some small nits inline. It would be great if we could also get a functional test. We're installing sunbeam as part of the CI, wonder if we could do an add-relation for identity and trafik route there as well?

@sabaini Thanks for the review. I am planning to add functional test for the integrations once the sunbeam changes are merged. However sunbeam changes will be part of 2024.1 rather than 2023.2, so i will update functional tests on next 2024.1/beta release (likely to be next week) once these PRs are merged.