search

canonical / charm-nrpe

A subordinate charm used to configure nrpe (Nagios Remote Plugin Executor)
Apache License 2.0
1 stars 6 forks source link

Consideration for passive LACP bond is missing #68

Open sudeephb opened 10 months ago

sudeephb commented 10 months ago

When the LACP bond is configured as passive on the switch, the LACP bonding status on the host will have a mismatch on the port state for each interface.

In this example, it will look this (excerpt from /proc/net/bonding/

details actor lacp pdu:     system priority: 65535     system mac address:     port key: 9     port priority: 255     port number: 1     port state: 61 details partner lacp pdu:     system priority: 32768     system mac address:     oper key: 41     port priority: 32768     port number: 554     port state: 60

So, the first bit is not matching. According to this[0], the first bit is "Active LACP is encoded as a 1; Passive LACP as a 0." Since the LACP is configured as passive on the switch, then this port mismatch is expected.

I believe it will be good to have an option to ignore that first bit of port mismatch when a passive LACP is configured.

[0] https://opendev.org/openstack/charm-magpie#port-state

Imported from Launchpad using lp2gh.

sudeephb commented 10 months ago

(by hudson-openstack) Fix proposed to branch: master Review: https://review.opendev.org/c/openstack/charm-magpie/+/846098

sudeephb commented 10 months ago

(by swalladge) https://review.opendev.org/c/openstack/charm-magpie/+/846098

sudeephb commented 10 months ago

(by hudson-openstack) Reviewed: https://review.opendev.org/c/openstack/charm-magpie/+/846098 Committed: https://opendev.org/openstack/charm-magpie/commit/abb21efbae9d9ae28cad0db5bd16aa0a0ce8fee4 Submitter: "Zuul (22348)" Branch: master

commit abb21efbae9d9ae28cad0db5bd16aa0a0ce8fee4 Author: Samuel Walladge 

Optionally ignore LACP activity bit in port check

If the LACP bond on the switch side is configured in passive mode,
the activity mode bit on the port states will usually be mismatched.

Add an option to the charm config to inform when this is expected,
so that the charm will ignore this mismatched bit when checking ports.

Closes-Bug: #1958327

Change-Id: I784bb410110813472e14b3477247fe138db5c214