search

canonical / charm-openstack-service-checks

Collection of Nagios checks and other utilities that can be used to verify the operation of an OpenStack cluster
0 stars 4 forks source link

Report downports as critical #184

Closed rgildein closed 2 weeks ago

rgildein commented 2 weeks ago

To test CI for #183

samuelallan72 commented 2 weeks ago

@rgildein why didn't the command comment work ( https://github.com/canonical/charm-openstack-service-checks/pull/183#issuecomment-2402700735 )?

chanchiwai-ray commented 2 weeks ago

@rgildein why didn't the command comment work ( #183 (comment) )?

Our CI depends on GH secret

samuelallan72 commented 2 weeks ago

Our CI depends on GH secret

I thought the command comment was designed to be the confirmation to run the CI and share secrets with the CI run?

chanchiwai-ray commented 2 weeks ago

I thought the command comment was designed to be the confirmation to run the CI and share secrets with the CI run?

That's two different things: the comment is for passing the compliance check; the secret not accessible by forks is an GitHub security feature(?)

rgildein commented 2 weeks ago

I thought the command comment was designed to be the confirmation to run the CI and share secrets with the CI run?

No it was design, that we can enable CI only. However, since it's running from fork it will not work.

gabrielcocenza commented 2 weeks ago

Closing because the CI passed and we already merged #183