nova_services and neutron_agent checks not being added to nrpe-external-master relation on newest O-S-C rev 16 and bionic-Rocky

[sudeephb]

I have a cloud where the /etc/nagios/nrpe.d/check_{nova_services,neutron_agents}.cfg files have been dropped by the charm into the directory, but the checks are not part of the relation data to nrpe:

$ cat /etc/nagios/nrpe.d/check_nova_services.cfg

check nova_services

The following header was added automatically by juju

Modifying it will affect nagios monitoring and alerting

servicegroups: bootstack-

command[check_nova_services]=/usr/local/lib/nagios/plugins/check_nova_services.py --warn 2 --crit 1 $ cat /etc/nagios/nrpe.d/check_neutron_agents.cfg

check neutron_agents

The following header was added automatically by juju

Modifying it will affect nagios monitoring and alerting

servicegroups: bootstack-

command[check_neutron_agents]=/usr/local/lib/nagios/plugins/check_neutron_agents.sh $ sudo juju-run nrpe-container/38 'relation-get -r 269 - openstack-service-checks/0'|egrep 'nova_services|neutron_agents' $ sudo juju-run nrpe-container/38 'relation-get -r 269 - openstack-service-checks/0'|egrep 'neutron' neutron_admin: command: check_neutron_admin neutron_admin_cert: command: check_neutron_admin_cert neutron_internal: command: check_neutron_internal neutron_internal_cert: command: check_neutron_internal_cert neutron_public: command: check_neutron_public neutron_public_cert: command: check_neutron_public_cert

---

Imported from Launchpad using lp2gh.

• date created: 2019-04-23T16:47:16Z

• owner: afreiberger

• assignee: aluria

• the launchpad url

[sudeephb]

(by aluria) I think this issue may be related to https://github.com/juju/charm-helpers/issues/312

I have shared a PR to address the "overwrite" problem in charmhelpers.

[sudeephb]

(by aluria) Change is pending to be released in the charm store.