Rewrite charm using template-python-pytests

[sudeephb]

Bug to track efforts to: 1) support unit and functional tests 2) rewrite the reactive script into modules (helpers)

---

Imported from Launchpad using lp2gh.

• date created: 2019-03-22T11:01:11Z

• owner: aluria

• assignee: aluria

• the launchpad url

[sudeephb]

(by aluria) 3 stacked MPs have been requested:

• [1] bug/1821316-rewrite-01-restruct -> master Integrates template-python-pytests into charm-openstack-service-checks current structure.

• [2] bug/1821316-rewrite-02-helpers -> bug/1821316-rewrite-01-restruct Moves help functions outside of the reactive script and into lib/.

• [3] bug/1821316-rewrite-03-addtests -> bug/1821316-rewrite-02-helpers Adds unit and functional tests, as well as fixes bugs found while creating the tests.

1. https://code.launchpad.net/~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks/+merge/364971
2. https://code.launchpad.net/~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks/+merge/364970
3. https://code.launchpad.net/~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks/+merge/364969

[sudeephb]

(by aluria) Reviews above have been approved. One final review [4] pending, to integrate the latest changes in template-python-pytest (ie. remove the "src/" folder):

4. https://code.launchpad.net/~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks/+merge/365243

[sudeephb]

(by aluria) Pushed to cs:~canonical-bootstack/openstack-service-checks-15