canonical / charm-prometheus-juju-exporter

Charm that deploys exporter, publishing statistics about juju-deployed machines
Apache License 2.0
1 stars 8 forks source link

fix: Change juju 3 support strategy #50

Closed jneo8 closed 6 months ago

jneo8 commented 7 months ago
dashmage commented 6 months ago

Since this testing strategy is a bit more different than what we're used to with other charms, it would be nice to include some documentation around this -- how we're testing the various juju versions, libjuju, zaza details, about env vars like TEST_JUJU_CHANNEL, TEST_JUJU etc.

jneo8 commented 6 months ago

Since this testing strategy is a bit more different than what we're used to with other charms, it would be nice to include some documentation around this -- how we're testing the various juju versions, libjuju, zaza details, about env vars like TEST_JUJU_CHANNEL, TEST_JUJU etc.

I feel it's should be document in zaza, not here. Right?

dashmage commented 6 months ago

Since this testing strategy is a bit more different than what we're used to with other charms, it would be nice to include some documentation around this -- how we're testing the various juju versions, libjuju, zaza details, about env vars like TEST_JUJU_CHANNEL, TEST_JUJU etc.

I feel it's should be document in zaza, not here. Right?

I was thinking more along the lines of how we are using zaza + other details specifically for these tests. But if it seems trivial, then we can ignore my comment. The changes LGTM :)

jneo8 commented 6 months ago

Cover by #52