canonical / charm-relation-interfaces

https://canonical.github.io/charm-relation-interfaces/
Apache License 2.0
16 stars 48 forks source link

feat: use team id as maintainers #173

Closed IronCore864 closed 1 month ago

IronCore864 commented 2 months ago

This PR changes the previous "owners", a list of GitHub user IDs, to "maintainers", a string of GitHub team ID. Assigning issues to a team is not supported, so an extra feature is added where user IDs are fetched from team ID.

More background:

Per discussions in this issue (see comment here and here) and an email thread, we have agreed to the followings:

This PR to charm-relation-interfaces reflects the above changes, see the other part in the pytest-interface-tester repo. Before merging into the main branch, it can’t be tested using GitHub Actions, but I’ve tested it in a forked repo in my own org, see here.

IronCore864 commented 2 months ago

Now that the PR for pytest-interface-tester is merged, this PR can be merged to use the latest pytest-interface-tester, v3.1.1, that has the "maintainer" feature.

Note that this PR needs to be merged first in order for the checks to pass.

IronCore864 commented 1 month ago

This PR can be merged since pytest-interface-tester 3.2.0 has been released with the maintainer feature, and the tests have been fixed, see passed checks below.

Squash all commits, sign, and merge now.