search

canonical / charm-relation-interfaces

https://canonical.github.io/charm-relation-interfaces/
Apache License 2.0
16 stars 48 forks source link

chore: bump to Scenario 7 #177

Closed tonyandrewmeyer closed 2 months ago

tonyandrewmeyer commented 2 months ago

Adjust the versions to use ops-scenario 7.0 (including connected packages) and adjust the one test that needs adjusting (as far as I can tell, there are no others).

IronCore864 commented 2 months ago

I was trying to fix the tests and accidentally created a duplicated PR, sorry for the duplicated work. I closed my PR.

If you search "changed_event", there are a few other interfaces (and a README) that have it. Shall we update them all?

tonyandrewmeyer commented 2 months ago

I was trying to fix the tests and accidentally created a duplicated PR, sorry for the duplicated work. I closed my PR.

Sorry, that might have been my fault. I thought you were going to get things working with pinned versions and I'd figure out the upgrading situation (which turned out to be way simpler than I thought). I might have misunderstood - sorry if I trod on your things.

If you search "changed_event", there are a few other interfaces (and a README) that have it. Shall we update them all?

Ah, you're right, those should be fixed as well. Why is it that they don't show up as failures? Do I have to run the matrix to have that happen?

IronCore864 commented 2 months ago

Why is it that they don't show up as failures?

Only the matrix tests for interfaces (triggered by this script) will run all tests, I think the unit tests and integration tests only run one interface as a validation.