canonical / charm-relation-interfaces

https://canonical.github.io/charm-relation-interfaces/
Apache License 2.0
16 stars 48 forks source link

Interface test for smtp v0 failed. #189

Open benhoyt opened 2 weeks ago

benhoyt commented 2 weeks ago

Tests for interface smtp v0 failed.

Provider

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/11713777734 for more detail.

@shipperizer, @BarcoMasile, @nsklikas, @wood-push-melon, @natalian98, @massigori, @canonical-iam, @pik4ez-canonical

natalian98 commented 2 weeks ago

@arturo-seijas @weiiwang01

weiiwang01 commented 2 weeks ago

It seems the error is caused by the saml-integrator charm, which uses the new union type syntax for Python 3.10, while the test is running on 3.8. Do we need to update the saml-integrator to be compatible with Python 3.8 or upgrade the interface test to run on Python 3.10?

https://github.com/canonical/charm-relation-interfaces/actions/runs/11713777734/job/32627184551#step:5:911

benhoyt commented 2 weeks ago

Tests for interface smtp v0 failed.

Provider

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/11769735758 for more detail.

@shipperizer, @BarcoMasile, @nsklikas, @wood-push-melon, @natalian98, @massigori, @canonical-iam, @pik4ez-canonical

weiiwang01 commented 1 week ago

@benhoyt @natalian98 I've added backward compatibility to the smtp-integrator charm for Python 3.8. Let me know if you encounter any other issues.