canonical / charm-sysconfig

A subordinate charm to apply system settings like grub configurations or systemd configurations.
Apache License 2.0
0 stars 5 forks source link

"console=ttyS0,115200 console=tty0" is hard coded and triggers reboot required unnecessarily #24

Closed dashmage closed 9 months ago

dashmage commented 9 months ago

juju deploy --series jammy sysconfig --config governor=performance juju add-relation sysconfig ""

Then, the sysconfig status becomes to:

update-grub and reboot required Changes in: /etc/default/grub.d/90-sysconfig.cfg, /etc/systemd/system.conf"

This is unexpected because:

  1. reboot is not required to apply CPU governor configuration since it can be on the fly.

  2. the charm is very opinionated about the GRUB config but it hardcodes tty0 and ttyS0 even when the system already had those values from MAAS kernel parameters.

[/etc/default/grub.d/90-sysconfig.cfg] GRUB_CMDLINE_LINUX_DEFAULT="" GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT console=ttyS0,115200 console=tty0"

  1. there is nothing changed in /etc/systemd/system.conf out of the box, but it triggers the reboot required flag just because of the timestamp.

Imported from Launchpad using lp2gh.

dashmage commented 9 months ago

(by nobuto) For the record, "clear-notification" action doesn't help in this case. It can delete the message after running the action, but it will come back whenever the next update-status hook is executed.

dashmage commented 9 months ago

(by nobuto) Basically the same thing as: https://bugs.launchpad.net/charm-sysconfig/+bug/1854135

But I was requested to file a new one.

dashmage commented 9 months ago

(by nobuto) Subscribing ~field-high.

dashmage commented 9 months ago

(by dashmage) "clear-notification" action is now fixed. Relevant code commit here: https://git.launchpad.net/charm-sysconfig/commit/?id=6f88d54f4e62c85ea9fd2595ab45f3f6d3d64db0

dashmage commented 9 months ago

(by nobuto) Re-opening as the point 3 is not addressed still:

  1. there is nothing changed in /etc/systemd/system.conf out of the box, but it triggers the reboot required flag just because of the timestamp.