search

canonical / charm-sysconfig

A subordinate charm to apply system settings like grub configurations or systemd configurations.
Apache License 2.0
0 stars 5 forks source link

Default PTI configuration is unexpected #27

Closed dashmage closed 2 months ago

dashmage commented 9 months ago

Just installing sysconfig the first time without particular charm configuration; the cmdline gets extended with pti=off. This may or may not be what the user expects, but it does change the default configuration. It's coming from how the template gets rendered: https://git.launchpad.net/charm-sysconfig/tree/src/templates/grub.j2#n32 and https://git.launchpad.net/charm-sysconfig/tree/src/config.yaml#n75

Would be better to have to change the config option in case you decide to need the config to be changed.

Imported from Launchpad using lp2gh.

dashmage commented 9 months ago

(by afreiberger) I do agree, we have set an opinionated default of disabling PTI by default, which, while a good practice, is against this catch-all charm's typical "make no changes without explicit configuration" mindset.

I feel like we should consider renaming the option as "disable-pti" and set it to "false" as default with some WARNING documentation in the description that this should be set to true to be protected at the cost of performance.

aieri commented 2 months ago

closing as resolved in #17