canonical / charm-sysconfig

A subordinate charm to apply system settings like grub configurations or systemd configurations.
Apache License 2.0
0 stars 5 forks source link

"reboot required" juju status message disappears even if update-grub was not run #31

Closed dashmage closed 9 months ago

dashmage commented 9 months ago

When update-grub is false, grub updates don't occur automatically when config is altered. This means reboots do not apply grub-config-flags automatically as well. However, a reboot does clear the "reboot required" messages related to the change in the grub config. This makes it a bit confusing, as the operator can believe the grub config was applied, even though it wasn't.

It would be nice to have a message that update-grub is needed to be run that persists after reboots. Or some message about grub not being updated after such reboot.


Imported from Launchpad using lp2gh.

dashmage commented 9 months ago

(by vultaire) I just got hit by this. I was trying to figure out why 1G hugepages weren't working on a customer's hugepage-enabled compute nodes, despite having everything configured in the sysconfig charm. Upon digging deeper, I found that the config option was set after the subordinate was deployed, and since the update-grub config option was false (per recommended default), the grub configs were not rewritten. As the node has been rebooted since the change was made, there was no indication in Juju status that it was necessary to run "update-grub" to finalize the changes.