search

canonical / charm-sysconfig

A subordinate charm to apply system settings like grub configurations or systemd configurations.
Apache License 2.0
0 stars 5 forks source link

Problem parsing complex values in grub-config-flags #38

Closed dashmage closed 8 months ago

dashmage commented 8 months ago

So I'm trying to properly isolate a real-time workload on OpenStack, and need to set "nohz_full" and "rcu_nocbs" for the same cores as was set in "isolcpus". There are no dedicated settings in the charm so I rely on setting grub-config-flags.

$ juju config sysconfig grub-config-flags='GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT nvme_core.multipath=0 nohz_full=22-39,62-79 rcu_nocbs=22-39,62-79"'

Renders (notice, a comma becomes a newline):

GRUB_CMDLINE_LINUX_DEFAULT=$GRUB_CMDLINE_LINUX_DEFAULT nvme_core.multipath=0 nohz_full=22-39 62-79 rcu_nocbs=22-39,62-79

while I would expect is to be: GRUB_CMDLINE_LINUX_DEFAULT=$GRUB_CMDLINE_LINUX_DEFAULT nvme_core.multipath=0 nohz_full=22-39,62-79 rcu_nocbs=22-39,62-79

Imported from Launchpad using lp2gh.

dashmage commented 8 months ago

(by eric-chen) This issue should be fixed in https://code.launchpad.net/~dashmage/charm-sysconfig/+git/charm-sysconfig/+merge/441304

Please test the version in edge channel. thanks!