Closed ajkavanagh closed 1 year ago
Hi, do you able to give me the repo of that reactive charm?
Hi, do you able to give me the repo of that reactive charm?
Sure, yes. it's https://opendev.org/openstack/charm-mysql-innodb-cluster
However, I'm converting it to a binary reactive charm (with lunar support), which is where I hit the issue: https://review.opendev.org/c/openstack/charm-mysql-innodb-cluster/+/886634
However, it should be reproducible with any charmcraft charm that uses the reactive plugin (note the review 886634 uses the reactive plugin, the master branch doesn't (yet)). Thanks.
Thanks very much for the fix @syu-w !
@ajkavanagh do you able to confirm it is working now?
@syu-w I can confirm that I've built the mysql-innodb-cluster charm with 2.3.0.post17+git35adadf
and the metadata.yam
, config.yaml
and actions.yaml
are all as per the generated output of charm build
. Also the lunar (23.04) base also works. Thanks!
Bug Description
It looks like PR#1126 may have broken charm-build (the reactive builders)
metadata.yaml
creation, as it seems to immediately overwrite it. This is with --channel=latest/edge (2.3.0.post16+gited81be8). At least I think that is what may be going on. I was testing latest/edge for the ability to build on lunar (23.04).The offending line appears to be at https://github.com/canonical/charmcraft/blob/ed81be89193deede1c4266c4c369ed7ce7d6b0be/charmcraft/commands/build.py#L181
The issue is that the built charms' metadata should look like this:
but actually looks like this:
To Reproduce
Environment
charmcraft.yaml
Relevant log output