search

canonical / charmcraft

Collaborate, build and publish charmed operators for Kubernetes, Linux and Windows.
Apache License 2.0
66 stars 69 forks source link

Flask extension. Allow charm-libs to be extended by the user #1718

Closed javierdelapuente closed 2 months ago

javierdelapuente commented 3 months ago

As pointed by @mr-cal in https://github.com/canonical/charmcraft/pull/1691#pullrequestreview-2156902965, the Flask extension fails when a charm-libs is already defined in a charmcraft.yaml, with a not very clear message because of an AttributeError exception.

This PR allows having a charm-libs in the original charmcraft.yaml, and will combine both charm-libs lists (if there are duplicated elements they will be only downloaded once).

javierdelapuente commented 2 months ago

Hi @lengau can you have a look at this PR. It addresses the issue pointed in https://github.com/canonical/charmcraft/pull/1691#pullrequestreview-2156902965. Thank you!

lengau commented 2 months ago

Looks good to me, thanks!