search

canonical / charmcraft

Collaborate, build and publish charmed operators for Kubernetes, Linux and Windows.
Apache License 2.0
64 stars 66 forks source link

Version 3 is not putting sub modules on hooks folder #1719

Open gabrielcocenza opened 3 days ago

gabrielcocenza commented 3 days ago

Bug Description

Building classical charms with version 3 is not adding the submodules like charmhelpers in the hooks folder.

So running a charm build with version 3 is breaking saying that it's not possible to find the module charmhelpers

To Reproduce

install charmcraft latest/edge

build a classic charm like charm-nrpe and deploy.

Environment

Ubuntu 22.04 LTS

charmcraft.yaml

type: charm

parts:
  charm:
    plugin: dump
    source: .
    prime:
      - actions/*
      - files/*
      - hooks/*
      - hooks/charmhelpers/*
      - templates/*
      - actions.yaml
      - config.yaml
      - copyright
      - LICENSE
      - metadata.yaml
      - README.md
bases:
    - build-on:
        - name: ubuntu
          channel: "20.04"
          architectures: ["amd64"]
      run-on:
        - name: ubuntu
          channel: "22.04"
          architectures:
              - amd64
        - name: ubuntu
          channel: "20.04"
          architectures:
              - amd64
        - name: ubuntu
          channel: "18.04"
          architectures:
              - amd64

Relevant log output

unit-nrpe-0: 12:44:22 INFO juju.worker.meterstatus skipped "meter-status-changed" hook (missing)
unit-nrpe-0: 12:44:22 WARNING unit.nrpe/0.install Traceback (most recent call last):
unit-nrpe-0: 12:44:22 WARNING unit.nrpe/0.install   File "/var/lib/juju/agents/unit-nrpe-0/charm/hooks/install", line 4, in <module>
unit-nrpe-0: 12:44:22 WARNING unit.nrpe/0.install     import services
unit-nrpe-0: 12:44:22 WARNING unit.nrpe/0.install   File "/var/lib/juju/agents/unit-nrpe-0/charm/hooks/services.py", line 11, in <module>
unit-nrpe-0: 12:44:22 WARNING unit.nrpe/0.install     from charmhelpers.core import hookenv
unit-nrpe-0: 12:44:22 WARNING unit.nrpe/0.install ModuleNotFoundError: No module named 'charmhelpers'
unit-nrpe-0: 12:44:22 ERROR juju.worker.uniter.operation hook "install" (via explicit, bespoke hook script) failed: exit status 1
unit-nrpe-0: 12:44:22 INFO juju.worker.uniter awaiting error resolution for "install" hook
unit-nrpe-0: 12:45:49 INFO juju.worker.uniter awaiting error resolution for "install" hook
unit-nrpe-0: 12:48:43 INFO juju.worker.uniter awaiting error resolution for "install" hook