search

canonical / charmcraft

Collaborate, build and publish charmed operators for Kubernetes, Linux and Windows.
Apache License 2.0
66 stars 69 forks source link

fix(charm_builder): force-install pip #1892

Closed lengau closed 3 weeks ago

lengau commented 3 weeks ago

The previous version wasn't installing pip if it was already in the venv.

This is the hotfix for 3.x, while https://github.com/canonical/charmcraft/pull/1891 is the hotfix for 2.x.

Fixes #1456 CRAFT-2538

lengau commented 3 weeks ago

@mattculler we only need to do so if the version of pip that's added in the venv is older than the minimum version that supports our needed feature set (as is the case on focal, for example). But we're checking the pip version before running that command.