canonical / charmed-5g

Charmed 5G is a secure, reliable and observable open source 5G network.

https://canonical-charmed-5g.readthedocs-hosted.com/

2 stars 0 forks source link

chore: bump juju version to 3.4 #195

Closed gruyaume closed 4 months ago

gruyaume commented 4 months ago

Description

Bump juju version to 3.4, this will be necessary for using log forwarding.

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that validate the behaviour of the software
[ ] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have bumped the version of the library

gruyaume commented 4 months ago

Minor nit, but we should not mix whitespace formatting changes in with PRs like this. I think @Gmerold's Terraform patches do this for the tables as well, so we're giving ourselves conflicts.

Yeah I agree though this can often be done automatically by IDE's (like in this case).