canonical / charmed-aether-sd-core

Charmed Aether SD-Core is a secure, reliable and observable open source 5G private mobile network.

https://canonical-charmed-aether-sd-core.readthedocs-hosted.com/en/latest/

Apache License 2.0

2 stars 2 forks source link

chore: modify product description #11

Closed solmyrcan closed 5 months ago

solmyrcan commented 5 months ago

Description

This PR includes some modifications to the description text for Charmed Aether SD-Core, and some minor text modifications as proposed improvements.

Checklist:

[ x] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that validate the behaviour of the software
[x ] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have bumped the version of the library

markbeierl commented 5 months ago

But it looks like your commits were not signed. We will have to go back and sign them.

solmyrcan commented 5 months ago

I have squashed the commits now and signature is in place. Please kindly review.

gruyaume commented 5 months ago

I have squashed the commits now and signature is in place. Please kindly review.

On the commits tab, you will see Verified next to signed commits. As as you can see, there are 11 commits in this PR, and 4 of them are not signed. All the commits need to be signed in order to be able to merge PR's.

To squash your commits into one, you can run the following from your branch:

git reset --soft HEAD~<num of commits>
git commit -S -m <your commit message"
git push --force

Here would be 11, and your commit message can be the same as your PR description chore: modify product description.

solmyrcan commented 5 months ago

Closing this pull request, as PR#16 is the new and clean one.