search

canonical / charmed-kubeflow-chisme

Shared Utilities used across Charmed Kubeflow
Apache License 2.0
1 stars 4 forks source link

[cos integration] Provide relation endpoint as function argument #111

Open rgildein opened 3 weeks ago

rgildein commented 3 weeks ago

Bug Description

Currently, the endpoint names for relations are defined as constant. e.g. APP_LOGGING, APP_METRICS_ENDPOINT and APP_GRAFANA_DASHBOARD

It would be good if this could be provided as argument for functions. For example, the APP_LOGGING should be the default value for logging endpoint in deploy_and_assert_grafana_agent and assert_logging functions.

To Reproduce

async def test_logging(ops_test):
    """Test logging is defined in relation data bag."""
    app = ops_test.model.applications[GRAFANA_AGENT_APP]
    await assert_logging(app, endpoint="my-logging")

Environment

Juju 3.4 Python 3.10

Relevant Log Output

no-logs

Additional Context

No response

syncronize-issues-to-jira[bot] commented 3 weeks ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5949.

This message was autogenerated