canonical / charmed-kubeflow-chisme

Shared Utilities used across Charmed Kubeflow
Apache License 2.0
1 stars 4 forks source link

`deepdiff>6.2.1` causes `error: can't find Rust compiler ` #42

Closed DnPlas closed 1 year ago

DnPlas commented 1 year ago

It seems like charms installing chisme's deepdiff dependency will end in error with the following message:

::    ::             running build_rust                                                                                          
::    ::             error: can't find Rust compiler                                                                             
::    ::                                                                                                                         
::    ::             If you are using an outdated pip version, it is possible a prebuilt wheel is available for this package but pip is not able to install from it. Installing from the wheel would avoid the need for a Rust compiler.      

Workaround

pin deepdiff==6.2.1 in charms

Solution

pin deepdiff in the setup.cfg file

ca-scribner commented 1 year ago

If we can pin this here that's great and I love the solution. I dont think we're expecting big improvements in deepdiff :)

If we cannot pin it, I say we remove the one usage. We don't use that part of chisme atm iirc, and could find a workaround if needed

DnPlas commented 1 year ago

@ca-scribner let's pin it and find a workaround later if needed? We use it in a very very very small part of chisme.

ca-scribner commented 1 year ago

yeah if pinning is solving this problem, I like pinning it