search

canonical / charmed-kubeflow-chisme

Shared Utilities used across Charmed Kubeflow
Apache License 2.0
1 stars 4 forks source link

add lightkube_client argument to KRH #69

Closed ca-scribner closed 6 months ago

ca-scribner commented 1 year ago

Adds an optional lightkube_client argument to the KubernetesResourceHandler. This is added to make for easier unit testing in charms. Without this, it can be challenging to mock the lightkube_client for KRHs that are instantiated in a charm's init. Using this dependency injection approach makes that easier.

i-chvets commented 1 year ago

LGTM. Need to fix tests and conflicts.

ca-scribner commented 6 months ago

Closed as stale