refactor `CheckRock` to add image name, improve clarify of API

canonical / charmed-kubeflow-chisme

Shared Utilities used across Charmed Kubeflow

Apache License 2.0

1 stars 4 forks source link

refactor `CheckRock` to add image name, improve clarify of API #81

Closed ca-scribner closed 7 months ago

ca-scribner commented 7 months ago

add get_name to return the image name
rename get_image_name() to get_rock_filename() to make it clearer what is return, and add the .rock extension to make it a full rock filename

Note: this may be a breaking change for some rock CI. imo it is a clearer API and I don't think any of our existing CI is working atm, but this should still be considered before merging.

ca-scribner commented 7 months ago

linting is broken in main and should be fixed by #82