canonical / charmed-kubeflow-chisme

Shared Utilities used across Charmed Kubeflow
Apache License 2.0
1 stars 4 forks source link

base charm: Enhance the pebble component to accept the contents of a file #89

Closed NohaIhab closed 6 months ago

NohaIhab commented 7 months ago

Context

ContainerFileTemplate currently accepts the path to a file, we've encountered use cases where we want to pass the file contents rather. For example, when the file content is created as part of the charm code like creating the certs. At the moment, the workaround for this is to create a temp file and pass the path of the temp file to ContainerFileTemplate i.e. read the temp file back in. Example of the workaround.

What needs to get done

modify the pebble component to accept file contents rather than just file paths in files_to_push

Definition of Done

  1. we can pass the file content to files_to_push
  2. tests are added for passing file content
  3. refactor the charms where we are doing the workaround mentioned in the context.
syncronize-issues-to-jira[bot] commented 7 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5432.

This message was autogenerated