canonical / charmed-kubeflow-chisme

Shared Utilities used across Charmed Kubeflow
Apache License 2.0
1 stars 4 forks source link

Implement functionality for custom images for air gap deployment #93

Open misohu opened 3 months ago

misohu commented 3 months ago

Context

We want to unify implementation for handling custom images in the charms. We can implement key functions like parse_image_config (example here) and get_images (example here).

Note: There might be two versions for for get_images where one does not handle splitting the images into name and tag and the other one is handling it.

What needs to get done

Implement the:

Use the functions in target charms. List (may not be complete please double check):

Definition of Done

  1. Functions are implemented tested and merged
  2. Function from chisme is used in the charms
syncronize-issues-to-jira[bot] commented 3 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5515.

This message was autogenerated

misohu commented 3 months ago

Process information: We have decided in this PR https://github.com/canonical/kfp-operators/pull/416 that we will not implement this feature as the fix implemented in that PR is timely pressured (there was not enough time to implement the feature and deliver the fix).