search

canonical / charmed-kubeflow-chisme

Shared Utilities used across Charmed Kubeflow
Apache License 2.0
1 stars 4 forks source link

Abstraction for testing the logging relation with grafana-agent-k8s #99

Closed rgildein closed 1 month ago

rgildein commented 1 month ago

Context

We will need to implement logging relation in Kubeflow charms and this relation should use LogForwarder from loki_push_api lib. This implementation will not require any abstraction in chime since it is really simple, however the #97 should be updated with common code for testing if the relation works fine.

This test needs to only check grafana-agent-k8s data bag and verify that endpoint key is there. We cannot check anything more, since we will not deploy Loki and Grafana agent is not log server, i.e. logs are not storead there.

What needs to get done

  1. Add logging relation in deploy function
  2. Add assert logging to testing cos abstraction
  3. Update README.md how to use it
  4. Unit tests and integrations tests, or at least example of manual tests

Definition of Done

  1. assert_logging function was added
  2. documentation was updated
  3. Functionality was tested
syncronize-issues-to-jira[bot] commented 1 month ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5768.

This message was autogenerated