search

canonical / charmed-kubeflow-uats

Automated UATs for Charmed Kubeflow
Apache License 2.0
6 stars 2 forks source link

UATs not working on host's python3.10 #79

Open misohu opened 4 months ago

misohu commented 4 months ago

Bug Description

UAT's will not work on tox installed on host's python3.10 (they only work on python3.8).

The bug was reported in this issue.

To Reproduce

  1. Run any Charmed Kubeflow deployment with juju (observer on juju 3.4 and CKF 1.8/stable)
  2. Run the UATs (observed with tox -e kubeflow-remote)

Environment

Observed on juju 3.4.4, aks v1.28.9, kubeflow 1.8/stable

Relevant Log Output

Log from here https://github.com/canonical/bundle-kubeflow/issues/951

Additional Context

No response

syncronize-issues-to-jira[bot] commented 4 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5958.

This message was autogenerated

kimwnasptd commented 4 months ago

@misohu @NohaIhab @DnPlas @orfeas-k what are the complications and cons of updating this, for the dev experience?

Can we convert the code to work for both Python 3.8 and 3.10?

misohu commented 4 months ago

Hey @kimwnasptd

If we wan to run on 3.10 we just need to migrate the requirements to 3.10 and maybe fix some issues. Right now the runners have 3.10 so we can completely drop the 3.8 support instead of supporting 2 pythons. WDYT?

mvlassis commented 4 months ago

We are planning on migrating to Python 3.10 for the tests. After that, support for Python 3.8 will be dropped.

motjuste commented 2 months ago

I have successfully run the tests with Python 3.10 after overriding the websockets requirement (transitively, via python-libjuju). To support both Python 3.8 and Python 3.9+, you'd then have to override websockets too based on Python version (as done by libjuju at that link).