search

canonical / charmed-kubeflow-workflows

Repository that containes GitHub workflows and shareable configs for Charmed Kubeflow
0 stars 0 forks source link

feat: Add workflow to build, scan and test a ROCK #26

Closed orfeas-k closed 9 months ago

orfeas-k commented 9 months ago

Add reusable workflow to build, scan and test a ROCK. This workflow comes from the kubeflow-rocks repo. I only renamed the input from rock to rock-dir since it represents better what its value should be.

Refs https://github.com/canonical/bundle-kubeflow/issues/692

orfeas-k commented 9 months ago

Once this is merged, we should update kubeflow-rocks on_pull_request.

orfeas-k commented 9 months ago

I 'm also OK with renaming the input back to rock since we already use this name in build_and_scan_rock.yaml.

ca-scribner commented 9 months ago

regarding renaming the inputs, I like rock-dir more myself mainly because I suspect in future we'll also have workflows that build a rock and pass the actual rock (x.rock), so that feels like a better use of the rock input