canonical / charmed-kubeflow-workflows

Repository that containes GitHub workflows and shareable configs for Charmed Kubeflow
0 stars 0 forks source link

feat(rocks): Refactor `on_pull_request` workflows #36

Closed orfeas-k closed 9 months ago

orfeas-k commented 9 months ago

This PR refactors on_pull_request-related workflows for our ROCKs CI. It mainly introduces new smaller workflows that are then called as jobs in bigger ones. This is heavily based on what telco team is doing in their ROCKs CI.

Notes

Python version

(copied from https://github.com/canonical/charmed-kubeflow-workflows/pull/36#issuecomment-1850337611) While triggering this workflow in seldonio-rocks repo, I noticed that integration tests may not be able to run when using Python 3.10 version as also mentioned https://github.com/canonical/katib-operators/issues/139. Thus, I added an input python-version in integration tests workflow which corresponds to which version we want to run our tests with.

In both of those example runs, I enabled publish on_pull_request while we have agreed to turn it off and keep it only for on_push events. We will not have to do this the above and https://github.com/canonical/bundle-kubeflow/issues/761 is resolved. It's the same reason we have a Setup Python 3.8 step in our bundle-kubeflow tests.

Refs https://github.com/canonical/charmed-kubeflow-workflows/issues/31 Closes https://github.com/canonical/charmed-kubeflow-workflows/issues/28 Closes https://github.com/canonical/charmed-kubeflow-workflows/issues/32 Closes https://github.com/canonical/charmed-kubeflow-workflows/issues/35

Issues that were raised during but not tackled by this PR

orfeas-k commented 9 months ago

While triggering this workflow in seldonio-rocks repo, I noticed that integration tests may not be able to run when using Python 3.10 version as also mentioned https://github.com/canonical/katib-operators/issues/139. Thus, I added an input python-version in integration tests workflow which corresponds to which version we want to run our tests with.

We will not have to do this the above and https://github.com/canonical/bundle-kubeflow/issues/761 is resolved. It's the same reason we have a Setup Python 3.8 step in our bundle-kubeflow tests.