search

canonical / charmed-kubeflow-workflows

Repository that containes GitHub workflows and shareable configs for Charmed Kubeflow
0 stars 0 forks source link

Update get-rocks-modified-and-build-scan-test-publish.yaml to allow defaults for `microk8s` and `juju-channel` #42

Closed ca-scribner closed 7 months ago

ca-scribner commented 7 months ago

This sets microk8s-channel and juju-channel to not be required. They have default values already so afaict they can be optional.

orfeas-k commented 7 months ago

We discussed with @ca-scribner and figured out that having those as optional and defining those versions centrally (instead of having to pin the versions in each repo) will result in us having to go back and send a pin versions in CI PR against new track branches that we cut, in each of the rocks repos.

For example, whenever we would decide to start using a newer versions of Microk8s, we would have to update this centrally in this repo. Then if we send a PR against an older track in a rock repo (that requires an earlier Microk8s version), it will fail and we will have to go back and pin it. On the flip side, having those inputs as required means that when we decide to bump versions, we 'll need to send a chore PR against main this time to each repo (just like what we do with charms repos atm).

Thus, we can have this discussion again during the ROCKs CI spec that is expected to be worked on in the coming weeks.