search

canonical / charmed-openstack-upgrader

Automatic upgrade tool for Charmed Openstack
Apache License 2.0
3 stars 12 forks source link

Refactor how to restart service when `enable-auto-restart` is False. #504

Closed chanchiwai-ray closed 4 months ago

chanchiwai-ray commented 4 months ago

Restart how to handle enable-auto-restarts=False in rabbitmq server.

I've tested with

juju deploy rabbitmq-server --channel 3.8/stable --base ubuntu@20.04 -n3 --config source=distro
juju config rabbitmq-server enable-auto-restarts=False
cou upgrade --no-backup --auto-approve --no-archive
chanchiwai-ray commented 4 months ago

I am moving get_run_deferred_hooks_and_restart_pre_upgrade_step and get_run_deferred_hooks_and_restart_post_upgrade_step to auxiliary.py since it was mentioned by https://github.com/canonical/charmed-openstack-upgrader/pull/503#discussion_r1682830528