search

canonical / charmed-openstack-upgrader

Automatic upgrade tool for Charmed Openstack
Apache License 2.0
3 stars 12 forks source link

Support `enable-auto-restarts=False` for ovn principal. #510

Closed chanchiwai-ray closed 4 months ago

chanchiwai-ray commented 4 months ago

Testing environment:

Using https://github.com/canonical/stsstack-bundles.git with ./generate-bundle.sh --name cou -r yoga -s jammy --ceph --run, then 

juju deploy ovn-dedicated-chassis --channel 22.03/stable --base ubuntu@22.04
juju config ovn-dedicated-chassis enable-version-pinning=False
juju integrate ovn-central:ovsdb     ovn-dedicated-chassis:ovsdb
juju integrate vault:certificates    ovn-dedicated-chassis:certificates
juju config ovn-dedicated-chassis bridge-interface-mappings=$(juju config ovn-chassis bridge-interface-mappings)
juju remove-relation nova-compute ovn-chassis
juju config ovn-central  enable-auto-restarts=False
juju config ovn-dedicated-chassis enable-auto-restarts=False
chanchiwai-ray commented 4 months ago

Looks good to me. Although I think we need at least manual confirmation the generated plan and a successful upgrade.

Testing right now

chanchiwai-ray commented 4 months ago

I will need to ask ovn team for confirmation: the run-deferred-hooks does not behavior like the doc says https://charmhub.io/ovn-dedicated-chassis/actions#run-deferred-hooks

ovn-central/1                            active    idle   14       10.5.1.129      6641-6642/tcp   Services queued for restart: ovn-central.service
ovn-central/2*                           active    idle   15       10.5.3.164      6641-6642/tcp   Services queued for restart: ovn-central.service
ovn-dedicated-chassis/0*                 active    idle   19       10.5.0.207                      Services queued for stop: ovs-record-hostname.service, ovs-vswitchd.service, ovsdb-server.service. Hooks skipped due ...
chanchiwai-ray commented 4 months ago

Closing it because the support of enable-auto-restarts=False for all OVN charms are not necessary, ovn charms / ovn can handle rolling upgrade themselves with enable-auto-restarts=True and enable-version-pinning=False and if ovn-central is upgraded before ovn-chassis.

https://docs.ovn.org/en/latest/intro/install/ovn-upgrades.html#rolling-upgrade