canonical / charmed-openstack-upgrader

Automatic upgrade tool for Charmed Openstack
Apache License 2.0
3 stars 12 forks source link

Workload verify step been skip if failed or timeout on upgrade step on COU re-run. #526

Closed jneo8 closed 2 weeks ago

jneo8 commented 3 months ago

For example in this plan:

Upgrade plan for 'ceph-mon' to 'antelope'                                                                                                                                                                                            
                        Upgrade software packages of 'ceph-mon' from the current APT repositories                                                                                                                                                    
                                Ψ Upgrade software packages on unit 'ceph-mon/0'                                                                                                                                                                     
                        Ensure that the 'require-osd-release' option matches the 'ceph-osd' version                                                                                                                                                  
                        Change charm config of 'ceph-mon' 'source' to 'cloud:jammy-antelope'                                                                                                                                                         
                        Wait for up to 2400s for model 'cou-t1' to reach the idle state                                                                                                                                                              
                        Verify that the workload of 'ceph-mon' has been upgraded on units: ceph-mon/0      

If we failed on Wait for up to 2400s for model 'cou-t1' to reach the idle state step, and we re-run the COU, the Verify that the workload of 'ceph-mon' has been upgraded on units: ceph-mon/0 step will not be trigger.

jneo8 commented 1 month ago

Note:

Now the verify workload version step is the only leave over step after wait for idle step. And verify workload version step is part of analysis step, which before generate the plan, so we won't be affect by this issue now.

Pjack commented 2 weeks ago

Close the issue based on James' comment.