search

canonical / charmed-openstack-upgrader

Automatic upgrade tool for Charmed Openstack
Apache License 2.0
3 stars 12 forks source link

[Bug] Should pass apps_control_plane to archive step #547

Closed jneo8 closed 2 weeks ago

jneo8 commented 2 weeks ago

The bug happen on below lines:

https://github.com/canonical/charmed-openstack-upgrader/blob/110e6f2f24746234754893047aa555354e42b442/cou/steps/plan.py#L579-L589

It should be:

    if args.archive:
        return [
            PreUpgradeStep(
                description="Archive old database data on nova-cloud-controller",
                coro=archive(
                    analysis_result.model,
                    # Should be apps_control_plane
                    analysis_result.apps_control_plane,
                    batch_size=args.archive_batch_size,
                ),
            )
        ]
chanchiwai-ray commented 2 weeks ago

Regression from https://github.com/canonical/charmed-openstack-upgrader/pull/534