canonical / charmed-zookeeper-rock

Zookeeper ROCK container
0 stars 2 forks source link

Creation of image from Snap #11

Closed welpaolo closed 1 year ago

welpaolo commented 1 year ago

This PR introduced the creation of image from the charmed-zookeeper-snap.

jardon commented 1 year ago

Is the reasoning for organizing all of the components into /opt because of permissions? The further away we get from the structure of the snap, the less useful it is to be based on it IMO

jardon commented 1 year ago

That being said, I'd like some other opinions. If that's the approach we're going for then I'd like to be consistent on my side as well.

deusebio commented 1 year ago

I honestly believe it is sane, given we are aiming to build charmed fat snap, where we bundle multiple components, I believe it makes sense to have the different components represented in the image as

/opt/workload1 /opt/workload2 /opt/workload3

We should probably rather stick to that, also in the SNAP for being consistent as you pointed out. This would make the snap path look a bit more verbose like

/snap/charmed-zookeeper/opt/zookeeper

but it makes sense to me because we are really having bundles here. Anyhow, @marcoppenheimer started to sum up a spec about packaging charm/rock/snap in a consistent way here

marcoppenheimer commented 1 year ago

I will revisit this layout next week and update the spec, can share with the group here on Monday for opinions?