fix: add a chip to integration tabs when required property is set to true in metadata.yaml

canonical / charmhub.io

GNU General Public License v3.0

9 stars 23 forks source link

fix: add a chip to integration tabs when required property is set to true in metadata.yaml #1851

Closed chillkang closed 1 week ago

chillkang commented 2 weeks ago

Done

When required property in metadata.yaml is set to true, the Required chip will be added to relevant side-nav items and endpoint headings.

How to QA

Currently, we don't have required property in metadata.yaml but this will be the standard.

Testing

[x] This PR has tests
[ ] No testing required (explain why):

Issue / Card

Fixes #https://warthogs.atlassian.net/browse/WD-9928

Screenshots

webteam-app commented 2 weeks ago

Demo

Jenkins

demos.haus

Lukewh commented 2 weeks ago

We seem to have lost the space between certificates and endpoint?

chillkang commented 2 weeks ago

https://charmhub-io-1851.demos.haus/postgresql-k8s/integrations

@Lukewh We should have the space back now!

lukasSerelis commented 2 weeks ago

+1 on what Luke said, it's the other way around.

Also, we'll need to put this on hold, apparently charmers don't use optional=true diligently, which would mean that it's not a good source of truth. Will update on this

lukasSerelis commented 2 weeks ago

Current solution is to pretend there is a required=true field in metadata.yaml or charmcraft.yaml and check for that. As we make it a standard it will be displayed in Charmhub.

lukasSerelis commented 1 week ago

Looks good!