search

canonical / charms.reactive

Framework for developing charms and relations using the reactive pattern
Apache License 2.0
22 stars 34 forks source link

Fix entry points #260

Closed wolsen closed 3 months ago

wolsen commented 3 months ago

While enabling noble, the entry_points are failing due to changes in the importlib apis from awhile back.

hloeung commented 3 months ago

Would https://github.com/canonical/charms.reactive/pull/251 help? Err, I mean https://github.com/canonical/charms.reactive/issues/237

wolsen commented 3 months ago

Would #251 help? Err, I mean #237

This would indeed address that bug.

addyess commented 2 months ago

Wow, super nice. I needed this and came looking for it. Thanks @ajkavanagh and @wolsen

is there any reason this isn't published to pypi?

ajkavanagh commented 2 months ago

is there any reason this isn't published to pypi?

Ah, yes, I should probably do that. I'll try to get it done tomorrow.

addyess commented 2 months ago

chances this still works in focal?

ajkavanagh commented 2 months ago

chances this still works in focal?

It should do. Although it was tested on 22.04, it passed tests with Python 3.7 and 3.8 and 3.8 was on focal (20.04).

addyess commented 2 months ago

@ajkavanagh i changed the wheelhouse on my charm to add this:

+  charms.reactive @ git+https://github.com/canonical/charms.reactive.git

and it works on noble and focal!
NICE!

addyess commented 2 months ago

@ajkavanagh I don't want to speak for him but @johnsca may not wish to be a maintainer any longer on https://pypi.org/project/charms.reactive/

Thanks for offering to publish a 1.5.3 or 1.6.0